kaxil commented on a change in pull request #14107:
URL: https://github.com/apache/airflow/pull/14107#discussion_r571116420
##########
File path: scripts/ci/images/ci_build_dockerhub.sh
##########
@@ -113,8 +113,8 @@ else
export DOCKER_CACHE="local"
# Name the image based on the TAG rather than based on the branch name
export FORCE_AIRFLOW_PROD_BASE_TAG="${DOCKER_TAG}"
- export INSTALL_AIRFLOW_VERSION="${DOCKER_TAG%-python*}"
- export
AIRFLOW_CONSTRAINTS_REFERENCE="constraints-${INSTALL_AIRFLOW_VERSION}"
+ export INSTALL_AIRFLOW_VERSION="==${DOCKER_TAG%-python*}"
Review comment:
I think what I am failing to understand is if `AIRFLOW_INSTALL_VERSION`
needs `==VERSION` or `<=VERSION` etc. How does
https://github.com/apache/airflow/blob/fc67521f31a0c9a74dadda8d5f0ac32c07be218d/.github/workflows/ci.yml#L489
work as it looks like `"--build-arg"
"AIRFLOW_INSTALL_VERSION=${INSTALL_AIRFLOW_VERSION}"` it is passed verbatim
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
