potiuk commented on a change in pull request #14107:
URL: https://github.com/apache/airflow/pull/14107#discussion_r571147783
##########
File path: scripts/ci/images/ci_build_dockerhub.sh
##########
@@ -113,8 +113,8 @@ else
export DOCKER_CACHE="local"
# Name the image based on the TAG rather than based on the branch name
export FORCE_AIRFLOW_PROD_BASE_TAG="${DOCKER_TAG}"
- export INSTALL_AIRFLOW_VERSION="${DOCKER_TAG%-python*}"
- export
AIRFLOW_CONSTRAINTS_REFERENCE="constraints-${INSTALL_AIRFLOW_VERSION}"
+ export INSTALL_AIRFLOW_VERSION="==${DOCKER_TAG%-python*}"
Review comment:
(side comment) The main reason why `INSTALL_AIRFLOW_VERSION` is used in
both PROD and CI is that we already had this and It was close enough in both CI
and PROD to reuse the same variable/breeze flaag. But yeah - they behave
differently and I think confusion that introduces is a a bit too much.
##########
File path: scripts/ci/images/ci_build_dockerhub.sh
##########
@@ -113,8 +113,8 @@ else
export DOCKER_CACHE="local"
# Name the image based on the TAG rather than based on the branch name
export FORCE_AIRFLOW_PROD_BASE_TAG="${DOCKER_TAG}"
- export INSTALL_AIRFLOW_VERSION="${DOCKER_TAG%-python*}"
- export
AIRFLOW_CONSTRAINTS_REFERENCE="constraints-${INSTALL_AIRFLOW_VERSION}"
+ export INSTALL_AIRFLOW_VERSION="==${DOCKER_TAG%-python*}"
Review comment:
(side comment) The main reason why `INSTALL_AIRFLOW_VERSION` is used in
both PROD and CI is that we already had this and It was close enough in both CI
and PROD to reuse the same variable/breeze flag. But yeah - they behave
differently and I think confusion that introduces is a a bit too much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
