potiuk commented on a change in pull request #14120:
URL: https://github.com/apache/airflow/pull/14120#discussion_r578050675
##########
File path: .github/workflows/build-images-workflow-run.yml
##########
@@ -204,6 +203,7 @@ jobs:
run-tests: ${{ steps.selective-checks.outputs.run-tests }}
run-kubernetes-tests: ${{
steps.selective-checks.outputs.run-kubernetes-tests }}
image-build: ${{ steps.selective-checks.outputs.image-build }}
+ githubRegistry: ${{
steps.determine-github-registry.outputs.githubRegistry }}
Review comment:
Actually it is even simpler. We can simply do
```
GITHUB_REGISTRY: ${{ secrets.GITHUB_REGISTRY_OVERRIDE }}
```
at the top of the build workflow. if the value is empty, the default (old
docker package) will be used. No need to use outputs in this workflow at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
