potiuk commented on a change in pull request #14120:
URL: https://github.com/apache/airflow/pull/14120#discussion_r578037626



##########
File path: scripts/ci/images/ci_wait_for_all_prod_images.sh
##########
@@ -15,6 +15,16 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+if [[ ${WAIT_FOR_IMAGE} != "true" ]]; then
+    # shellcheck source=scripts/in_container/_in_container_script_init.sh
+    . "$( dirname "${BASH_SOURCE[0]}" )/../libraries/_script_init.sh"
+    echo
+    echo "Not waiting for all PROD images to appear as they are built locally 
in this build"
+    echo
+    push_pull_remove_images::determine_github_registry

Review comment:
       Yeah. I figured that we can do it this way when I saw how you've done 
the self-hosted selection. It was not clear before that '' value was 'falsy' in 
the expression language. It makes the whole workflow logic much simpler. I was 
not hurrying with that as INFRA is not in a hurry with providing a token for us 
(only today Gavin assigned the ticket to himself, so I hope it will happen 
soon).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to