ferruzzi commented on a change in pull request #14402:
URL: https://github.com/apache/airflow/pull/14402#discussion_r583775797
##########
File path: airflow/providers/amazon/aws/hooks/s3.py
##########
@@ -848,3 +848,74 @@ def generate_presigned_url(
except ClientError as e:
self.log.error(e.response["Error"]["Message"])
return None
+
+ @provide_bucket_name
+ def get_bucket_tagging(self, bucket_name: Optional[str] = None) ->
Optional[List[Dict[str, str]]]:
+ """
+ Gets a List of tags from a bucket.
+
+ :param bucket_name: The name of the bucket.
+ :type bucket_name: str
+ :return: A List containing the key/value pairs for the tags
+ :rtype: Optional[List[Dict[str, str]]]
Review comment:
This mirrors how the API behaves. I'm not positive why the API is
returning it that way, but didn't presume to change it and possibly break
someone's implementation. It's an easy enough change if we would prefer to
unwrap it. What do you think?
Reference:
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3.html#S3.Client.get_bucket_tagging
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
