o-nikolas commented on a change in pull request #14402:
URL: https://github.com/apache/airflow/pull/14402#discussion_r583832338
##########
File path: airflow/providers/amazon/aws/hooks/s3.py
##########
@@ -848,3 +848,74 @@ def generate_presigned_url(
except ClientError as e:
self.log.error(e.response["Error"]["Message"])
return None
+
+ @provide_bucket_name
+ def get_bucket_tagging(self, bucket_name: Optional[str] = None) ->
Optional[List[Dict[str, str]]]:
+ """
+ Gets a List of tags from a bucket.
+
+ :param bucket_name: The name of the bucket.
+ :type bucket_name: str
+ :return: A List containing the key/value pairs for the tags
+ :rtype: Optional[List[Dict[str, str]]]
Review comment:
I'd prefer that we keep the standard S3 Boto API behaviour. Diverging
from the API will lead to confusion, especially for folks that are moving
standalone Python code over to Airflow and it's operators.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
