xinbinhuang commented on a change in pull request #12677:
URL: https://github.com/apache/airflow/pull/12677#discussion_r583918098
##########
File path: airflow/operators/sql.py
##########
@@ -120,16 +148,16 @@ def _convert_to_float_if_possible(s):
return ret
-class SQLValueCheckOperator(BaseOperator):
+class SQLValueCheckOperator(BaseSQLOperator):
Review comment:
I think so, the refactor on this operator is mainly to reduce duplicated
code, and the logic, interface, and signature don't change in a backward
incompatible one. But I don't know enough about how providers are released and
how the core may affect it. cc @potiuk (sorry to ping you again..)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
