xinbinhuang commented on a change in pull request #12677:
URL: https://github.com/apache/airflow/pull/12677#discussion_r582219579
##########
File path: airflow/providers/google/cloud/hooks/bigquery.py
##########
@@ -69,8 +69,8 @@ class BigQueryHook(GoogleBaseHook, DbApiHook):
conn_name_attr = 'gcp_conn_id'
default_conn_name = 'google_cloud_default'
- conn_type = 'google_cloud_platform'
- hook_name = 'Google Cloud'
+ conn_type = 'bigquery'
+ hook_name = 'BigQuery'
Review comment:
> Does it needs any action from a user side is why I am thinking about
it ? -- if yes, then we might need a note somewhere in Up:
https://github.com/apache/airflow/blob/master/airflow/providers/google/cloud/ADDITIONAL_INFO.md
Hmm, I think we need a note for it. From sole user perspective, the
conn_type for BigQuery changes from `Google Cloud` -> `Google BigQuery`.
However, if we don't change it the current master branch will break anything
that relies on `Connection.get_hook` to return a `BigQueryHook`.
Should I update the providers' version by 0.0.1 and add a note to the
`ADDITIONAL_INFO.md` or other documentation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
