vemikhaylov commented on a change in pull request #14501:
URL: https://github.com/apache/airflow/pull/14501#discussion_r587259860
##########
File path: tests/api_connexion/schemas/test_task_instance_schema.py
##########
@@ -199,7 +199,6 @@ def test_success(self):
@parameterized.expand(
[
({"task_id": None},),
- ({"include_future": "True"},),
Review comment:
To be quite honest, I'm not sure what exactly are we going to test by
this thing? I suppose that we shouldn't test the Marshmallow functionality
(i.e. correctness of `fields.Boolean` work) as it's not our area of
responsibility. However, if we would like to do so, why not all the fields are
tested on loading any wrong type with failure? What's specific about this
`include_future` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
