ephraimbuddy commented on a change in pull request #14501:
URL: https://github.com/apache/airflow/pull/14501#discussion_r587283929
##########
File path: tests/api_connexion/schemas/test_task_instance_schema.py
##########
@@ -199,7 +199,6 @@ def test_success(self):
@parameterized.expand(
[
({"task_id": None},),
- ({"include_future": "True"},),
Review comment:
The OpenAPI spec validates these things for us. We shouldn't even be
writing many of these Marshmallow schemas tests but since it's part of our code
now and we are writing it, we should write it correctly.
And there's nothing specific about the `include_future`, it's just like
other fields. Since we have tests for the other fields, let's also have a test
for it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
