ashb commented on a change in pull request #14792:
URL: https://github.com/apache/airflow/pull/14792#discussion_r594210751
##########
File path: tests/jobs/test_scheduler_job.py
##########
@@ -2638,6 +2638,7 @@ def
test_scheduler_verify_pool_full_2_slots_per_task(self):
execution_date=date,
state=State.RUNNING,
)
+ SerializedDagModel.write_dag(dag)
Review comment:
Please move outside the loop to L2633
##########
File path: tests/jobs/test_scheduler_job.py
##########
@@ -2589,8 +2589,8 @@ def test_scheduler_verify_pool_full(self):
execution_date=dag.following_schedule(dr.execution_date),
state=State.RUNNING,
)
+ SerializedDagModel.write_dag(dag)
Review comment:
This should be above line 2586 I think
##########
File path: tests/jobs/test_scheduler_job.py
##########
@@ -2822,6 +2824,7 @@ def test_verify_integrity_if_dag_changed(self):
assert scheduler.dagbag.dags ==
{'test_verify_integrity_if_dag_changed': dag}
assert
len(scheduler.dagbag.dags.get("test_verify_integrity_if_dag_changed").tasks) ==
1
+ SerializedDagModel.write_dag(dag=dag)
Review comment:
This one doesn't seem like it would be needed as two lines later we
write it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
