potiuk commented on pull request #14792: URL: https://github.com/apache/airflow/pull/14792#issuecomment-799758821
> This can be achieved with a much smaller code change, and in such a way that new tests can't get this wrong, [using `__del__`](https://docs.python.org/3/reference/datamodel.html#object.__del__) I wanted to minimize the "airflow" code change and focused only on changing the tests. are you sure it will not have any effects int he airflow code? Destructors are dangerous because they are usually changing behaviour of garbage collecting experience in the life code. Are you sure it is absolutely safe to add the destructors? Do we really want to impact the production code in order to fix the flaky tests? Or do you think it should be there in the first place ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
