bovoleg commented on issue #5035: [AIRFLOW-4239] Synchronize airflow execution timeout and aws batch job timeout URL: https://github.com/apache/airflow/pull/5035#issuecomment-480170120 Hello, The “execution_timeout” argument is the parameter of the every airflow job. It is already well described in the documentation and in the BaseOperator class. My suggested changes does not override its behavior, but just setup the AWS Batch execution timeout to the same value, which allows to synch task execution expectations between airflow and AWS Batch. Without this changes Airflow may fail the task in 20 minutes when AWS batch may have timeout to 1 hours continues execution and success. Oleg. Від: Ash Berlin-Taylor <[email protected]> Надіслано: 5 апреля 2019 г. 0:50 Кому: apache/airflow <[email protected]> Копія: Oleg Burlachenko <[email protected]>; Mention <[email protected]> Тема: Re: [apache/airflow] [AIRFLOW-4239] Synchronize airflow execution timeout and aws batch job timeout (#5035) @ashb requested changes on this pull request. At the very least the parameter will need adding to the doc string, and it should mention the behaviour. I'm not sure that setting the execution_timeout of the task to exactly the same value is right either - that will stop the task a little before the timeout on Batch (due to other processing). Not sureif that is a problem though. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://github.com/apache/airflow/pull/5035#pullrequestreview-223019365>, or mute the thread<https://github.com/notifications/unsubscribe-auth/Ak52oFIJGVBGr-5TtjyU6zHS--L1f_krks5vdnORgaJpZM4ccq-j>.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
