bovoleg commented on issue #5035: [AIRFLOW-4239] Synchronize airflow execution timeout and aws batch job timeout URL: https://github.com/apache/airflow/pull/5035#issuecomment-480618121 The goal of this change is to setup AWS batch timeout to the same value as airflow batch timeout. This value is already exists in the BatchOperator declaration :param execution_timeout: max time allowed for the execution of this task instance, if it goes beyond it will raise and fail. So I think if add additional parameter we still may have a situation when AWS batch timeout and airflow timeout has different values, which I think we should avoid. Oleg Burlachenko Від: Fokko Driesprong <[email protected]> Надіслано: 5 апреля 2019 г. 15:18 Кому: apache/airflow <[email protected]> Копія: Oleg Burlachenko <[email protected]>; Mention <[email protected]> Тема: Re: [apache/airflow] [AIRFLOW-4239] Synchronize airflow execution timeout and aws batch job timeout (#5035) @Fokko commented on this pull request. ________________________________ In airflow/contrib/operators/awsbatch_operator.py<https://github.com/apache/airflow/pull/5035#discussion_r272560358>: > @@ -75,7 +76,7 @@ def __init__(self, job_name, job_definition, job_queue, overrides, max_retries=4 self.job_queue = job_queue self.overrides = overrides self.max_retries = max_retries - + self.execution_timeout = kwargs.get('execution_timeout', timedelta(seconds=3600)) I would suggest not pulling this from the kwargs and make it an argument with a default value. WDYT? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://github.com/apache/airflow/pull/5035#pullrequestreview-223240666>, or mute the thread<https://github.com/notifications/unsubscribe-auth/Ak52oMbGYxoIFCT9DbznewjYQzHRHt3aks5vdz79gaJpZM4ccq-j>.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
