ericpp commented on a change in pull request #14869:
URL: https://github.com/apache/airflow/pull/14869#discussion_r597376439
##########
File path: airflow/providers/mysql/hooks/mysql.py
##########
@@ -52,7 +52,10 @@ def __init__(self, *args, **kwargs) -> None:
def set_autocommit(self, conn: Connection, autocommit: bool) -> None: #
noqa: D403
"""MySql connection sets autocommit in a different way."""
- conn.autocommit(autocommit)
+ if hasattr(conn, 'get_autocommit'): # mysqlclient
+ conn.autocommit(autocommit)
+ else: # mysql-connector-python
+ conn.autocommit = autocommit
Review comment:
Thanks! I like option two because it directly tests the thing it's
trying to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
