ericpp commented on a change in pull request #14869:
URL: https://github.com/apache/airflow/pull/14869#discussion_r597432774
##########
File path: airflow/providers/mysql/hooks/mysql.py
##########
@@ -52,7 +52,10 @@ def __init__(self, *args, **kwargs) -> None:
def set_autocommit(self, conn: Connection, autocommit: bool) -> None: #
noqa: D403
Review comment:
Do you have to import both modules before you can use their names for a
`Union` typing? If so, I would need to figure out if having them both imported
at the same time would cause any issues. It looks like the `get_conn()` method
is only importing one module depending on the value of `client_name`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
