ephraimbuddy commented on a change in pull request #14895:
URL: https://github.com/apache/airflow/pull/14895#discussion_r599939991
##########
File path: airflow/api_connexion/parameters.py
##########
@@ -86,3 +87,32 @@ def wrapped_function(*args, **kwargs):
return cast(T, wrapped_function)
return format_parameters_decorator
+
+
+def apply_sorting(model, query, order_by, to_replace=None, allowed_attrs=None):
+ """Apply sorting to query"""
+ lstriped_orderby = order_by.lstrip('-')
+ if allowed_attrs and lstriped_orderby not in allowed_attrs:
+ modelname = model.__tablename__.capitalize()
+ model_mapping = {
+ "Ab_user": 'User',
+ "Slot_pool": "Pool",
+ "Dag_run": "DagRun",
+ "Dag": "DagModel",
+ "Ab_role": "Role",
+ "Import_error": "ImportError",
+ }
+ if model_mapping.get(modelname, None):
+ modelname = model_mapping[modelname]
+ raise BadRequest(
+ detail=f"Ordering with '{lstriped_orderby}' is disallowed or "
+ f"the attribute does not exist on {modelname} model"
+ )
+ if to_replace:
+ for key, value in to_replace.items():
+ if key == order_by:
+ order_by = value
Review comment:
Awesome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
