uranusjr commented on a change in pull request #14895:
URL: https://github.com/apache/airflow/pull/14895#discussion_r598735077



##########
File path: airflow/api_connexion/openapi/v1.yaml
##########
@@ -376,6 +376,8 @@ paths:
       parameters:
         - $ref: '#/components/parameters/PageLimit'
         - $ref: '#/components/parameters/PageOffset'
+        - $ref: '#/components/parameters/SortBy'
+        - $ref: '#/components/parameters/OrderBy'

Review comment:
       This would also avoid the `sort="desc", order_by=None` I mentioned 
below. `order_by=<field>` and `order_by=-<field>` are handled by the first 
branches, and the third handles a missing `order_by`. So another :+1: here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to