ericpp commented on a change in pull request #14869:
URL: https://github.com/apache/airflow/pull/14869#discussion_r601646361



##########
File path: tests/providers/mysql/hooks/test_mysql.py
##########
@@ -184,6 +197,20 @@ def setUp(self):
         self.db_hook.get_connection = mock.Mock()
         self.db_hook.get_connection.return_value = self.connection
 
+        class FakeMySQLConnection(object):

Review comment:
       I've reworked this to have the fake object extend the `mock.MagicMock` 
class so that the property checks in `mysql.py` pass and so that the mock 
assertions can be used.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to