dstandish commented on a change in pull request #14869:
URL: https://github.com/apache/airflow/pull/14869#discussion_r602441645



##########
File path: airflow/providers/mysql/hooks/mysql.py
##########
@@ -52,7 +52,10 @@ def __init__(self, *args, **kwargs) -> None:
 
     def set_autocommit(self, conn: Connection, autocommit: bool) -> None:  # 
noqa: D403

Review comment:
       @ericpp i know you were working through the right way to test this 
autocommit fix, but it seems you added a bunch of tests that are unrelated to 
this change?  can you remove the tests that don't have anything to do with this 
PR? perhaps i'm missing something?
   
   after you do that, i'll take a look and see if we need to make any 
adjustments, or if you have specific questions i can try to address them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to