davlum edited a comment on pull request #15013: URL: https://github.com/apache/airflow/pull/15013#issuecomment-810443658
@dstandish If you read the description of PR you can see an example of `get_uri` failing. The fact is that connection URI is a lossy format and is required by Vault integration. As somebody who manages several Airflow instances and had to migrate all the tenants connections into Vault this was a breaking change as users who did not have unnested JSON had their connection broken when calling `.get_uri()` on it. It was then required to go in and manually change the application code for tenants that used their `extra` parameters to use the appropriate format. This is not a good workflow. > There is a benefit inherent in having only one perfectly good way to do things. There does not currently exist one perfectly good way to do things. There are two incompatible ways, and the main interface users use is the `Connection` object. All values of `Connection` cannot be serialized to connection URI. If you want `get_uri` to be a legitimate format you need to do validation on the `Connection` object to verify that it serializes properly. This would be a breaking change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
