dstandish commented on pull request #15013:
URL: https://github.com/apache/airflow/pull/15013#issuecomment-810477193


   Yeah you make a good point that it can't store arbitrary json _(I do imagine 
we could add support for this within the URI format)_.
   
   Based on that assumption, we do have [fairly comprehensive 
tests](https://github.com/apache/airflow/blob/master/tests/models/test_connection.py#L308-L358)
 that verify that URI parsing and URI generation produce consistent results.
   
   But it's true we don't test the case where you store an arbitrary value in 
extra such as `hello` or `fubar`.
   
   Currently it is assumed dict, so like `{'hello': 'fubar'}`
   
   Anyway I'll let others chime in at this point.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to