dstandish commented on pull request #15013:
URL: https://github.com/apache/airflow/pull/15013#issuecomment-810604429
@avieth
>However, AFAICT, the constructor will not check this, and will not fail
when extra is not JSON. But get_uri does check this (implicitly, by trying to
decode then urlencode), and so we have the very weird case in which we can
construct a Connection object for which get_uri fails, as @davlum has shown.
I'd say that's fairly counterintuitive and surprising.
> Is there a good reason why extra must be encoded JSON? Seems like a nice
solution would be to allow for any string there
OK i was able to add support in get_uri for arbitrary i.e. non-json string
in #15100. behavior is still to return `{}` when you call `extra_dejson` in
this case. However, it can now be serialized to URI and back without loss.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
