davlum commented on a change in pull request #15013:
URL: https://github.com/apache/airflow/pull/15013#discussion_r606665776
##########
File path: airflow/providers/hashicorp/secrets/vault.py
##########
@@ -18,8 +18,10 @@
"""Objects relating to sourcing connections & variables from Hashicorp Vault"""
from typing import Optional
+from airflow.models.connection import Connection
from airflow.providers.hashicorp._internal_client.vault_client import
_VaultClient # noqa
from airflow.secrets import BaseSecretsBackend
+from airflow.secrets.local_filesystem import _create_connection
Review comment:
In this particular case I can see this function existing in
`airflow.models.connections` as `from_dict() -> Connection`. Transforming a
dict to the object is the sort of function that usually exists with the class.
I agree with the general case that something needs to be done about common
functionality between providers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
