mik-laj commented on a change in pull request #15013:
URL: https://github.com/apache/airflow/pull/15013#discussion_r606666991



##########
File path: airflow/providers/hashicorp/secrets/vault.py
##########
@@ -18,8 +18,10 @@
 """Objects relating to sourcing connections & variables from Hashicorp Vault"""
 from typing import Optional
 
+from airflow.models.connection import Connection
 from airflow.providers.hashicorp._internal_client.vault_client import 
_VaultClient  # noqa
 from airflow.secrets import BaseSecretsBackend
+from airflow.secrets.local_filesystem import _create_connection

Review comment:
       You can't add a new feature to the core because we want to be backwards 
compatible with Airflow 2.0.0.  I opened the discussions to loosen this 
restriction, because they do not conform to reality. I think we should maintain 
backward compatibility with the MINOR release, not the MAJOR. 
   
   I invite you to the discussion on the mailing list if you would like to 
share your thoughts.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to