kaxil commented on a change in pull request #15314:
URL: https://github.com/apache/airflow/pull/15314#discussion_r611171506
##########
File path: docs/helm-chart/manage-dags-files.rst
##########
@@ -91,10 +96,27 @@ This option will use a Persistent Volume Claim with an
access mode of ``ReadWrit
# by setting the dags.persistence.* and dags.gitSync.* values
# Please refer to values.yaml for details
+When using ``apache-airflow>=2.0.0``, :ref:`DAG Serialization
<apache-airflow:dag-serialization>` is enabled by default,
+hence Webserver does not need access to DAG files, so you can turn off
``git-sync`` for Webserver by setting
+``dags.gitSync.excludeWebserver`` to ``true``.
+This is also recommended when enabling DAG Serialization for
``apache-airflow>=1.10.7,<2``.
Review comment:
We had removed the default and have a fallback of `True` for
`store_dag_code` for Airflow >=1.10.11
https://github.com/apache/airflow/blob/5da831910c358ecbd7a5c33ee31fe0d909508bea/airflow/settings.py#L460-L462
https://github.com/apache/airflow/blob/5da831910c358ecbd7a5c33ee31fe0d909508bea/airflow/config_templates/default_airflow.cfg#L205-L209
Same for 1.10.11:
https://github.com/apache/airflow/blob/1.10.11/airflow/config_templates/default_airflow.cfg#L237-L242
where the value is same as `store_serialized_dags`:
https://github.com/apache/airflow/blob/1.10.11/airflow/settings.py#L431-L434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
