mik-laj commented on a change in pull request #15314:
URL: https://github.com/apache/airflow/pull/15314#discussion_r611215956
##########
File path: docs/helm-chart/manage-dags-files.rst
##########
@@ -91,10 +96,27 @@ This option will use a Persistent Volume Claim with an
access mode of ``ReadWrit
# by setting the dags.persistence.* and dags.gitSync.* values
# Please refer to values.yaml for details
+When using ``apache-airflow>=2.0.0``, :ref:`DAG Serialization
<apache-airflow:dag-serialization>` is enabled by default,
+hence Webserver does not need access to DAG files, so you can turn off
``git-sync`` for Webserver by setting
+``dags.gitSync.excludeWebserver`` to ``true``.
+This is also recommended when enabling DAG Serialization for
``apache-airflow>=1.10.11,<2``.
+
+.. code-block:: bash
+
+ helm upgrade airflow . \
+ --set dags.persistence.enabled=true \
+ --set dags.gitSync.enabled=true \
+ --set dags.gitSync.excludeWebserver=true
+ # you can also override the other persistence or gitSync values
+ # by setting the dags.persistence.* and dags.gitSync.* values
+ # Please refer to values.yaml for details
+
Mounting DAGs using Git-Sync sidecar without Persistence
--------------------------------------------------------
-This option will use an always running Git-Sync side car on every scheduler,
webserver and worker pods. The Git-Sync side car containers will sync DAGs from
a git repository every configured number of seconds. If you are using the
KubernetesExecutor, Git-sync will run as an init container on your worker pods.
+This option will use an always running Git-Sync side car on every scheduler,
webserver and worker pods.
Review comment:
```suggestion
This option will use an always running Git-Sync sidecar on every scheduler,
webserver and worker pods.
```
##########
File path: docs/helm-chart/manage-dags-files.rst
##########
@@ -91,10 +96,27 @@ This option will use a Persistent Volume Claim with an
access mode of ``ReadWrit
# by setting the dags.persistence.* and dags.gitSync.* values
# Please refer to values.yaml for details
+When using ``apache-airflow>=2.0.0``, :ref:`DAG Serialization
<apache-airflow:dag-serialization>` is enabled by default,
+hence Webserver does not need access to DAG files, so you can turn off
``git-sync`` for Webserver by setting
+``dags.gitSync.excludeWebserver`` to ``true``.
+This is also recommended when enabling DAG Serialization for
``apache-airflow>=1.10.11,<2``.
+
+.. code-block:: bash
+
+ helm upgrade airflow . \
+ --set dags.persistence.enabled=true \
+ --set dags.gitSync.enabled=true \
+ --set dags.gitSync.excludeWebserver=true
+ # you can also override the other persistence or gitSync values
+ # by setting the dags.persistence.* and dags.gitSync.* values
+ # Please refer to values.yaml for details
+
Mounting DAGs using Git-Sync sidecar without Persistence
--------------------------------------------------------
-This option will use an always running Git-Sync side car on every scheduler,
webserver and worker pods. The Git-Sync side car containers will sync DAGs from
a git repository every configured number of seconds. If you are using the
KubernetesExecutor, Git-sync will run as an init container on your worker pods.
+This option will use an always running Git-Sync side car on every scheduler,
webserver and worker pods.
+The Git-Sync side car containers will sync DAGs from a git repository every
configured number of
Review comment:
```suggestion
The Git-Sync sidecar containers will sync DAGs from a git repository every
configured number of
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
