ephraimbuddy commented on a change in pull request #15295:
URL: https://github.com/apache/airflow/pull/15295#discussion_r611461639
##########
File path: airflow/www/security.py
##########
@@ -170,7 +190,11 @@ def __init__(self, appbuilder):
if not view or not getattr(view, 'datamodel', None):
continue
view.datamodel = CustomSQLAInterface(view.datamodel.obj)
+ app = self.appbuilder.get_app
self.perms = None
+ # Custom cookie session interface
+ # Override to implement your custom cookie session interface
+ app.session_interface = DefaultSessionInterface()
Review comment:
Cool. But I'm of the opinion that users won't be able to modify the
session when set at airflow.www.extensions.init_session?
Also, I think that some of the initialization at airflow.www.extensions can
be refactored by moving them into the security manager. The security manager
also gets called in create_app through airflow.www.extensions.init_appbuilder.
So it's still the same I think but users can be able to override a lot using
just the security manager
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
