potiuk commented on a change in pull request #14:
URL:
https://github.com/apache/airflow-client-python/pull/14#discussion_r619644050
##########
File path: setup.py
##########
@@ -23,11 +23,9 @@
Generated by: https://openapi-generator.tech
"""
-from os import path
from setuptools import setup, find_packages # noqa: H301
-NAME = "apache-airflow-client"
VERSION = "1.0.0"
Review comment:
```suggestion
VERSION = "2.0.0"
```
##########
File path: setup.cfg
##########
@@ -17,3 +17,22 @@
[flake8]
max-line-length=99
+
+[metadata]
+name = apache-airflow-client
+description = Apache Airflow API (Stable)
+author = Apache Software Foundation
+author_email = [email protected]
+url = https://airflow.apache.org/
+long_description = file: README.md
+long_description_content_type = text/markdown
+license = Apache License 2.0
+project_urls =
+ Documentation=https://airflow.apache.org/docs/
Review comment:
```suggestion
Documentation=https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html
```
##########
File path: setup.py
##########
@@ -23,11 +23,9 @@
Generated by: https://openapi-generator.tech
"""
-from os import path
from setuptools import setup, find_packages # noqa: H301
-NAME = "apache-airflow-client"
VERSION = "1.0.0"
Review comment:
I think @msumit manually updated it (I checked in PyPI and they are ok +
I think twine would reject it if the name <> version
##########
File path: setup.cfg
##########
@@ -17,3 +17,22 @@
[flake8]
max-line-length=99
+
+[metadata]
+name = apache-airflow-client
+description = Apache Airflow API (Stable)
+author = Apache Software Foundation
+author_email = [email protected]
+url = https://airflow.apache.org/
+long_description = file: README.md
+long_description_content_type = text/markdown
+license = Apache License 2.0
+project_urls =
+ Documentation=https://airflow.apache.org/docs/
Review comment:
The link is with "stable" and I think it is good as is - API is more of
a property of Airflow not the client, so it conceptually belongs to Airflow.
##########
File path: setup.cfg
##########
@@ -17,3 +17,22 @@
[flake8]
max-line-length=99
+
+[metadata]
+name = apache-airflow-client
+description = Apache Airflow API (Stable)
+author = Apache Software Foundation
+author_email = [email protected]
+url = https://airflow.apache.org/
+long_description = file: README.md
+long_description_content_type = text/markdown
+license = Apache License 2.0
+project_urls =
+ Documentation=https://airflow.apache.org/docs/
Review comment:
But yeah, I agree at some point in time we might want to have "Updating
guide" for the client. So I agree eventually we should have a section for
clients like we have "providers" and "docker-stack" now.
##########
File path: setup.cfg
##########
@@ -17,3 +17,22 @@
[flake8]
max-line-length=99
+
+[metadata]
+name = apache-airflow-client
+description = Apache Airflow API (Stable)
+author = Apache Software Foundation
+author_email = [email protected]
+url = https://airflow.apache.org/
+long_description = file: README.md
+long_description_content_type = text/markdown
+license = Apache License 2.0
+project_urls =
+ Documentation=https://airflow.apache.org/docs/
Review comment:
In this case we should likely have a completely separate "Airflow API"
section and have sub-sections for:
```
1) API specs
2) Clients
- Python
- Go ....
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
