kaxil commented on a change in pull request #14:
URL:
https://github.com/apache/airflow-client-python/pull/14#discussion_r619647859
##########
File path: setup.py
##########
@@ -23,11 +23,9 @@
Generated by: https://openapi-generator.tech
"""
-from os import path
from setuptools import setup, find_packages # noqa: H301
-NAME = "apache-airflow-client"
VERSION = "1.0.0"
Review comment:
oh wait was the version 1.0.0 in the released candidate?
##########
File path: setup.cfg
##########
@@ -17,3 +17,22 @@
[flake8]
max-line-length=99
+
+[metadata]
+name = apache-airflow-client
+description = Apache Airflow API (Stable)
+author = Apache Software Foundation
+author_email = [email protected]
+url = https://airflow.apache.org/
+long_description = file: README.md
+long_description_content_type = text/markdown
+license = Apache License 2.0
+project_urls =
+ Documentation=https://airflow.apache.org/docs/
Review comment:
I feel we should have separate docs for the python-client so that we can
also have an Updating guide
##########
File path: setup.cfg
##########
@@ -17,3 +17,22 @@
[flake8]
max-line-length=99
+
+[metadata]
+name = apache-airflow-client
+description = Apache Airflow API (Stable)
+author = Apache Software Foundation
+author_email = [email protected]
+url = https://airflow.apache.org/
+long_description = file: README.md
+long_description_content_type = text/markdown
+license = Apache License 2.0
+project_urls =
+ Documentation=https://airflow.apache.org/docs/
Review comment:
coz
https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html
has the version of the API and it might be confusing
##########
File path: setup.cfg
##########
@@ -17,3 +17,22 @@
[flake8]
max-line-length=99
+
+[metadata]
+name = apache-airflow-client
+description = Apache Airflow API (Stable)
+author = Apache Software Foundation
+author_email = [email protected]
+url = https://airflow.apache.org/
+long_description = file: README.md
+long_description_content_type = text/markdown
+license = Apache License 2.0
+project_urls =
+ Documentation=https://airflow.apache.org/docs/
Review comment:
Exactly my point :)
##########
File path: setup.py
##########
@@ -23,11 +23,9 @@
Generated by: https://openapi-generator.tech
"""
-from os import path
from setuptools import setup, find_packages # noqa: H301
-NAME = "apache-airflow-client"
VERSION = "1.0.0"
Review comment:
Yup just checked
##########
File path: setup.py
##########
@@ -23,12 +23,10 @@
Generated by: https://openapi-generator.tech
"""
-from os import path
from setuptools import setup, find_packages # noqa: H301
-NAME = "apache-airflow-client"
-VERSION = "1.0.0"
+VERSION = "2.0.0"
Review comment:
Yeah: let's change it to `2.1.0.dev`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
