BenoitHanotte edited a comment on pull request #15423:
URL: https://github.com/apache/airflow/pull/15423#issuecomment-828186014


   > The red-green mixing doesn't seem right. I don't know if we just have to 
play with the function you already have or use a different one like this: 
https://www.geeksforgeeks.org/d3-js-interpolaterdylgn-function/
   > 
   > Code-wise things look good to me. I think we still need to refine the UI. 
I'll pull it down again and experiment a bit.
   
   The interpolation function `interpolaterdylgn` does not interpolate between 
green and red but between 3 colors: green, yellow and red. We can't hardcode 
these colors in the UI as the backend is responsible for providing the status 
colors to the UI.
   I can however easily change the interpolation function from `interpolateRgb` 
to `interpolateHsl` which does the interpolation in the HSL space and thus goes 
from green to red through yellow. It gives the following colors:
   
![image](https://user-images.githubusercontent.com/6229788/116356890-c2ade580-a7f3-11eb-82ea-bb95509bbcdd.png)
   
   I have 2 concerns with this approach though:
   1. yellow is already used as the color for the `up_for_retry` and 
`upstream_failed` task instance statuses. Displaying a day as yellow might be 
misleading to users as they might think there is a just task that will be 
retried that day?
   2. As you can see on the screenshot above, day with just a few failures (Jan 
15 and 16) are displayed as light green, which might not make it obvious that 
that day has not been processed correctly. I fear this might be misleading and 
misunderstood by users.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to