potiuk commented on pull request #15705: URL: https://github.com/apache/airflow/pull/15705#issuecomment-834353457
> Can you explain the timeout thing? I don't see how changing the default back to an int will change much of anything, given the int value will already exist in user's config files. Sure. I can't recall the exact scenario right now, but it was more because of errors generated when building/testing the providers. The change is part of the "Fix a problem with building PROD image". As I remember what happens is that when we install Airflow 1.10.* in the CI image prepared for 2.0, the config file was present and the migration was using 1.10 code to read it. However, I am happy to restore the original values in this change and I will see if I can reproduce the problem in master and will fix it there as well differently (just removing the generated airflow config should do the trick).. I see the point where the "30.0" value indicates that you can add fractional values is better than "30". This will anyhow become non-issue very soon when we stop supporting 1.10 entirely. > There are more commits here than I would have expected -- for instance seem uncnecsarry on first glance: > > [9389e95](https://github.com/apache/airflow/commit/9389e95090e079edc5ac0b3df22c59b31aa9fae3) > [0963ecd](https://github.com/apache/airflow/commit/0963ecd5b5de99605451297b5db1f04a25190472) > [492f843](https://github.com/apache/airflow/commit/492f843225f05b5bfbe8e17401da1181473f9621) (we don't build providers from release branch) This is mainly because some of the files in those changes (like breeze/scripts) are common with other updates which were necessary (mainly because of optimisations of Docker image building (limiting number of layers) and PIP 21 compliance (changes to some common scripts where we excluded beam etc.). This is FAR easier to cherry-pick all those changes to relevant files rather than trying to only cherry-pick the docker building stuff (it would lead to conflicts and possibly the changes will end-up there anyway but in non-relevant commits). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
