uranusjr commented on a change in pull request #15794:
URL: https://github.com/apache/airflow/pull/15794#discussion_r630955451



##########
File path: docs/apache-airflow-providers-apache-spark/connections/spark.rst
##########
@@ -27,7 +27,7 @@ The Apache Spark connection type enables connection to Apache 
Spark.
 Default Connection IDs
 ----------------------
 
-Spark Submit and Spark JDBC hooks and operators use ``spark_default`` by 
default, Spark SQL hooks and operators point to ``spark_sql_default`` by 
default, but don't use it.
+Spark Submit and Spark JDBC hooks and operators use ``spark_default`` by 
default, Spark SQL hooks and operators point to ``spark_sql_default`` by 
default, but its usage is optional.

Review comment:
       > I would completely remove the `, but its usage is optional`, I think 
it is the normal behaviour for any connection.
   
   Is it? IIRC the Connection is *not* optional for most hooks; they fail with 
`AirflowNotFoundException` if a matching Connection is not found.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to