uranusjr opened a new pull request #15794: URL: https://github.com/apache/airflow/pull/15794
Fix #8713. This takes a different approach from previous work (#12710); instead of deprecating anything, the configuration is now resolved in a two-step process: 1. If an argument is explicitly passed in by the user, it is used (the current ebhaviour), and configuration on the Conenction object is ignored. A try block is added so the Connection is not needed if the user wants to explicitly pass in everything. 2. If the user does not pass in configuration arguments explicitly, the configuration is populated by a Connection object (if available). This is straightforward for most of the arguments, but three requires special treatment: `master`, `name`, and `verbose`, since they have a default value if not provided explicitly. So if the user does not pass them, *and* a Connection entry is not available, they are set to the default value instead (`'yarn"`, `"default-name"`, and `True` respectively). There should I document this behaviour? At least we should write down what `extra` keys the user can use to configure the hook. --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
