ashb commented on a change in pull request #5089: [AIRFLOW-4255] Make GCS Hook
Backwards compatible
URL: https://github.com/apache/airflow/pull/5089#discussion_r274907621
##########
File path: airflow/contrib/hooks/gcs_hook.py
##########
@@ -187,8 +189,15 @@ def upload(self, bucket, object, filename,
:type mime_type: str
:param gzip: Option to compress file for upload
:type gzip: bool
+ :param multipart: Deprecated parameter. Multipart would be handled
automatically
+ :type multipart: bool or int
+ :param num_retries: Deprecated parameter. Retries would be handled
automatically
+ :type num_retries: int
"""
+ warnings.warn("'multipart' and 'num_retries' parameters have been
deprecated."
Review comment:
I would suggest passing `multipart=None` and then an `if multipart is not
None` -- otherwise there is no way for the user to "fix" this warning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
