ashb commented on a change in pull request #5089: [AIRFLOW-4255] Make GCS Hook
Backwards compatible
URL: https://github.com/apache/airflow/pull/5089#discussion_r275307378
##########
File path: airflow/contrib/hooks/gcs_hook.py
##########
@@ -265,6 +275,10 @@ def delete(self, bucket, object):
:param object: name of the object to delete
:type object: str
"""
+
+ if generation is not None:
+ warnings.warn("'generation' parameter is no longer supported",
DeprecationWarning)
Review comment:
We should add a `stacklevel=2` to all these warn calls - that way the
warning will be reported with the filename/line number of the caller, rather
than `gcs_hook;py:280: generation' parameter is no longer supported`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
