potiuk edited a comment on pull request #16048:
URL: https://github.com/apache/airflow/pull/16048#issuecomment-852177035


   No worries. This is my fault :D I overlooked it and I have not yet released 
the providers (I will wait until this is fixed). And It has really very little 
impact (if at all). The `get_uri` method for the HTTP hook is really not used. 
The hook uses `schema` field to build the URI. The `get_uri" method is used 
only to display connection details in "aiflow connections list/get" commands as 
far as I know.  However yeah - someone **could** use it potentially in their 
DAGS/custom operators. 
   
   I think the easiest way to fix is to return a new HTTPConnection(Connection) 
object in 'get_connection()" method of the HTTPHook. This new `HTTPConnection` 
hook could simply replace the schema in their `get_uri()" method to 'http' or 
whatever the `schema` is.
   
   I think that would be fully backwards compatible and behave "as expected".  
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to