potiuk commented on pull request #16048:
URL: https://github.com/apache/airflow/pull/16048#issuecomment-852209192


   There is a little difficulty in this because Connection is the SQLAlchemy 
model so this is not as easy as deriving from it. I am tempted to monkeypatch 
the `get_uri()` method of the Connection object in this case rather than derive 
from it. 
   
   This is a bit of a hack and results from lack of consistency how HTTP Hook 
treats schema/how other connections are building URIs (using conn_type for URI 
is terrible idea that's why I have not even checked it). So we should likely 
address it in 2.2 (I think we can) but for now maybe just monkeypatching is the 
best option?  @uranusjr @ashb WDYT? 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to