potiuk commented on a change in pull request #16411:
URL: https://github.com/apache/airflow/pull/16411#discussion_r650449833
##########
File path: clients/gen/go.sh
##########
@@ -25,7 +25,7 @@ readonly CLEANUP_DIRS
# shellcheck source=./clients/gen/common.sh
source "${CLIENTS_GEN_DIR}/common.sh"
-VERSION=1.1.0
+VERSION=2.0.0
Review comment:
Hm. I remember we discussed versioning, but can't find it quickly. My
memory is not the best recently (got some disruptions and distractions) but if
I remember correctly, we agreed to only follow MAJOR release, assuming that
most recent MAJOR client will work with Any MAJOR version of airflow (and in
this case 2.0.0 is perfectly fine).
But I might be wrong - does anyone remember where we had that discussion and
did we capture the result of it.?
##########
File path: clients/gen/go.sh
##########
@@ -25,7 +25,7 @@ readonly CLEANUP_DIRS
# shellcheck source=./clients/gen/common.sh
source "${CLIENTS_GEN_DIR}/common.sh"
-VERSION=1.1.0
+VERSION=2.0.0
Review comment:
@kaxil @ashb ?
##########
File path: clients/gen/go.sh
##########
@@ -25,7 +25,7 @@ readonly CLEANUP_DIRS
# shellcheck source=./clients/gen/common.sh
source "${CLIENTS_GEN_DIR}/common.sh"
-VERSION=1.1.0
+VERSION=2.0.0
Review comment:
Ah. So my memory is failing me. Do you remember where the discussion was
@msumit ? I think we need to capture it somewhere (unless it's already captured
and I just did not find it :) ) ?
##########
File path: clients/gen/go.sh
##########
@@ -25,7 +25,7 @@ readonly CLEANUP_DIRS
# shellcheck source=./clients/gen/common.sh
source "${CLIENTS_GEN_DIR}/common.sh"
-VERSION=1.1.0
+VERSION=2.0.0
Review comment:
Thanks! Yeah. I remembered everything except the final conclusion :).
I created https://github.com/apache/airflow/pull/16422 with an attempt to
capture all the SemVer rules we discussed so far. Happy to iterate and merge :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
