ephraimbuddy commented on a change in pull request #16301:
URL: https://github.com/apache/airflow/pull/16301#discussion_r650878667
##########
File path: airflow/jobs/local_task_job.py
##########
@@ -151,16 +147,16 @@ def signal_handler(signum, frame):
self.on_kill()
def handle_task_exit(self, return_code: int) -> None:
- """Handle case where self.task_runner exits by itself"""
+ """Handle case where self.task_runner exits by itself or received a
sigkill/sigterm"""
self.log.info("Task exited with return code %s", return_code)
self.task_instance.refresh_from_db()
- # task exited by itself, so we need to check for error file
+ # We need to check for error file
# in case it failed due to runtime exception/error
error = None
if self.task_instance.state == State.RUNNING:
- # This is for a case where the task received a sigkill
+ # This is for a case where the task received a sigkill or sigterm
Review comment:
```suggestion
# This is for a case where the task received a SIGKILL
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
