ephraimbuddy commented on a change in pull request #16301:
URL: https://github.com/apache/airflow/pull/16301#discussion_r650881572



##########
File path: tests/jobs/test_local_task_job.py
##########
@@ -513,16 +514,10 @@ def task_function(ti):
         assert task_terminated_externally.value == 1
         assert not process.is_alive()
 
-    @parameterized.expand(
-        [
-            (signal.SIGTERM,),
-            (signal.SIGKILL,),
-        ]
-    )
-    @pytest.mark.quarantined
-    def test_process_kill_calls_on_failure_callback(self, signal_type):
+    @parameterized.expand([(signal.SIGKILL,), (signal.SIGTERM,)])
+    def test_task_sigkill_sigterm_calls_on_failure_callback(self, sigtype):
         """
-        Test that ensures that when a task is killed with sigterm or sigkill
+        Test that ensures that when a task is killed with sigkill

Review comment:
       ```suggestion
           Test that ensures that when a task is killed with sigterm or sigkill 
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to