ecerulm commented on a change in pull request #16631:
URL: https://github.com/apache/airflow/pull/16631#discussion_r658087235
##########
File path: airflow/serialization/serialized_objects.py
##########
@@ -195,6 +196,19 @@ def serialize_to_json(
serialized_object[key] = value
return serialized_object
+ @classmethod
+ def serialize_timezone(cls, var: datetime.tzinfo) -> Any:
+ """Serializes a timezone to json"""
+ tz_name = getattr(var, 'name', None)
+ if not tz_name:
+ try:
+ tz_name = var.tzname(datetime.datetime.utcnow())
+ except InvalidTimezone:
+ raise TypeError(f"the timezone {var} can't be serialized")
Review comment:
yes, probably just best to catch `Exception` to be honest, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
