ecerulm commented on a change in pull request #16631:
URL: https://github.com/apache/airflow/pull/16631#discussion_r658127417
##########
File path: tests/serialization/test_dag_serialization.py
##########
@@ -446,6 +447,26 @@ def validate_deserialized_task(
datetime(2019, 8, 1, tzinfo=timezone.utc),
),
(pendulum.datetime(2019, 8, 1, tz='UTC'), None,
pendulum.datetime(2019, 8, 1, tz='UTC')),
+ (
+ pendulum.parse("2019-08-01T00:00:00.000+00:00"),
+ None,
+ pendulum.parse("2019-08-01T00:00:00.000+00:00"),
+ ),
+ (
+ pendulum.parse("2019-08-01T00:00:00.000+01:30"),
+ None,
+ pendulum.parse("2019-08-01T00:00:00.000+01:30"),
+ ),
+ (
+ pendulum.datetime(2019, 8, 1, tz='Europe/Stockholm'),
+ None,
+ pendulum.datetime(2019, 8, 1, tz='Europe/Stockholm'),
+ ),
+ (
+ pendulum.datetime(2019, 8, 1, tz=FixedTimezone(3600)),
+ None,
+ pendulum.datetime(2019, 8, 1, tz=FixedTimezone(3600)),
+ ),
]
Review comment:
> Maybe coupled with tz_name in pendulum.tz.timezones?
I'm not sure what you mean , but if you mean to use `.tzname()` instead of
`.name` I can already tell you that is even more brittle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
