ecerulm commented on a change in pull request #16686:
URL: https://github.com/apache/airflow/pull/16686#discussion_r659601856
##########
File path: airflow/models/taskinstance.py
##########
@@ -1670,6 +1696,9 @@ def get(
'json': VariableJsonAccessor(),
'value': VariableAccessor(),
},
+ 'conn': {
+ 'value': ConnectionAccessor(),
+ },
Review comment:
But don't we want consistency between the var accessor syntax and the
connection accessor syntax? I mean, assuming people is already familiar with
syntax `var.value.my_connection` I guess they will try
`conn.value.my_connection` and not `conn.my_connection`.
If you already pondered about that and still think the `conn.my_connectio`
is preferrable just tell me and I'll change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
