ecerulm edited a comment on pull request #16686: URL: https://github.com/apache/airflow/pull/16686#issuecomment-869507309
> Logic looks good to me, but this won’t pass static checks (formatting issues). Please try to run those locally and fix them first. I did run those locally prior to submitting the PR. `pre-commit run` did not complain for me: ``` git fetch origin pre-commit run --from-ref $(git merge-base origin/main jinjaconn) --to-ref jinjaconn identity.................................................................................Passed - hook id: identity - duration: 0.11s airflow/models/taskinstance.py tests/models/test_taskinstance.py Check hooks apply to the repository..................................(no files to check)Skipped No-tabs checker..........................................................................Passed Add license for all SQL files........................................(no files to check)Skipped Add license for all other files......................................(no files to check)Skipped Add license for all rst files........................................(no files to check)Skipped Add license for all JS/TS/TSX/CSS/PUML files.........................(no files to check)Skipped Add license for all JINJA template files.............................(no files to check)Skipped Add license for all shell files......................................(no files to check)Skipped Add license for all Python files.........................................................Passed Add license for all XML files........................................(no files to check)Skipped Add license for all YAML files.......................................(no files to check)Skipped Add license for all md files.........................................(no files to check)Skipped Add license for all mermaid files....................................(no files to check)Skipped Add TOC for md files.................................................(no files to check)Skipped black....................................................................................Passed blacken-docs.............................................................................Passed Check for merge conflicts................................................................Passed Debug Statements (Python)................................................................Passed Check builtin type constructor use.......................................................Passed Detect Private Key.......................................................................Passed Fix End of Files.........................................................................Passed Mixed line ending........................................................................Passed Check that executables have shebangs.................................(no files to check)Skipped Check Xml............................................................(no files to check)Skipped Trim Trailing Whitespace.................................................................Passed Fix python encoding pragma...............................................................Passed Pretty format JSON...................................................(no files to check)Skipped pyupgrade................................................................................Passed rst ``code`` is two backticks........................................(no files to check)Skipped use logger.warning(......................................................................Passed Check YAML files with yamllint.......................................(no files to check)Skipped Run isort to sort imports in Python files................................................Passed Run pydocstyle...........................................................................Passed Lint OpenAPI using spectral..........................................(no files to check)Skipped Lint OpenAPI using openapi-spec-validator............................(no files to check)Skipped Lint dockerfile......................................................(no files to check)Skipped Check order of dependencies in setup.cfg and setup.py................(no files to check)Skipped Checks setup extra packages..........................................(no files to check)Skipped Update output of breeze command in BREEZE.rst........................(no files to check)Skipped Update mounts in the local yml file..................................(no files to check)Skipped Update setup.cfg file with all licenses..............................(no files to check)Skipped Build cross-dependencies for providers packages......................(no files to check)Skipped Update extras in documentation.......................................(no files to check)Skipped Check for pydevd debug statements accidentally left......................................Passed Don't use safe in templates..........................................(no files to check)Skipped No providers imports in core example DAGs............................(no files to check)Skipped No relative imports......................................................................Passed Check for language that we do not accept as community....................................Passed Check for inconsistent pylint disable/enable without space...............................Passed Check BaseOperator[Link] core imports....................................................Passed Check BaseOperator[Link] other imports...............................(no files to check)Skipped Check provide_session and create_session imports.........................................Passed Make sure LoggingMixin is not used alone.................................................Passed Make sure days_ago is imported from airflow.utils.dates..................................Passed 'start_date' should not be defined in default_args in example_dags...(no files to check)Skipped Check if integration list is aligned.................................(no files to check)Skipped Check if licenses are OK for Apache..................................(no files to check)Skipped Checks for consistency between config.yml and default_config.cfg.....(no files to check)Skipped Verify that DB Migrations have been documented.......................(no files to check)Skipped Checks for Boring Cyborg configuration consistency.......................................Passed Sort INTHEWILD.md alphabetically.....................................(no files to check)Skipped Sort alphabetically and uniquify spelling_wordlist.txt...............(no files to check)Skipped Lint Helm Chart......................................................(no files to check)Skipped Check Shell scripts syntax correctness...............................(no files to check)Skipped Run BATS bash tests for changed Breeze bash files....................(no files to check)Skipped Run BATS bash tests for changed bash files...........................(no files to check)Skipped stylelint............................................................(no files to check)Skipped Provider init file.......................................................................Passed Validate providers.yaml files........................................(no files to check)Skipped Generate mermaid images..............................................(no files to check)Skipped Check if pre-commits are described...................................(no files to check)Skipped Ensure hook ids are not overly long..................................(no files to check)Skipped Checks providers available when declared by extras in setup.py.......(no files to check)Skipped Run markdownlint.....................................................(no files to check)Skipped Lint JSON Schema files with JSON Schema..............................(no files to check)Skipped Lint NodePort Service with JSON Schema...............................(no files to check)Skipped Lint Docker compose files with JSON Schema...........................(no files to check)Skipped Lint chart/values.schema.json file with JSON Schema..................(no files to check)Skipped Lint chart/values.yaml file with JSON Schema.........................(no files to check)Skipped Lint airflow/config_templates/config.yml file with JSON Schema.......(no files to check)Skipped Convert to f-strings with flynt..........................................................Passed ESLint against airflow/ui............................................(no files to check)Skipped ESLint against current UI js files...................................(no files to check)Skipped Run in container bats tests..........................................(no files to check)Skipped Check if image build is needed...........................................................Passed Run mypy.................................................................................Passed Run mypy for helm chart tests........................................(no files to check)Skipped Run mypy for /docs/ folder...........................................(no files to check)Skipped Run pylint for main code.................................................................Passed Run pylint for tests.....................................................................Passed Run pylint for helm chart tests......................................(no files to check)Skipped Run flake8...............................................................................Passed ``` Also it seems to be passing the static checks in CI too https://github.com/apache/airflow/pull/16686/checks?check_run_id=2929988055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
