JPonte commented on a change in pull request #16141:
URL: https://github.com/apache/airflow/pull/16141#discussion_r661200808
##########
File path: airflow/www/decorators.py
##########
@@ -53,7 +54,10 @@ def wrapper(*args, **kwargs):
)
if 'execution_date' in request.values:
- log.execution_date =
pendulum.parse(request.values.get('execution_date'), strict=False)
+ try:
+ log.execution_date =
pendulum.parse(request.values.get('execution_date'), strict=False)
+ except ParserError:
+ pass
Review comment:
If we can't parse the execution date, we can't store it in the execution
date column since it is typed. It should still be preserved in the extras
though: `extra=str([(k, v) for k, v in request.values.items() if k not in
fields_skip_logging]),`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
