JPonte commented on a change in pull request #16141:
URL: https://github.com/apache/airflow/pull/16141#discussion_r661495126
##########
File path: airflow/www/decorators.py
##########
@@ -53,7 +54,10 @@ def wrapper(*args, **kwargs):
)
if 'execution_date' in request.values:
- log.execution_date =
pendulum.parse(request.values.get('execution_date'), strict=False)
+ try:
+ log.execution_date =
pendulum.parse(request.values.get('execution_date'), strict=False)
+ except ParserError:
+ pass
Review comment:
It is being flashed as an error on the location it happens:
https://github.com/apache/airflow/pull/16141/files#diff-917b70d2661fae8322c538a4f60b9d4ba755556036fe0c527eb0411a6ac60f2eR1517
This is a decorator for user activity logging as far as I understand.
Doesn't seem like it should be its concern to validate and surface user input
issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
