uranusjr commented on a change in pull request #16845:
URL: https://github.com/apache/airflow/pull/16845#discussion_r664968581
##########
File path: airflow/api_connexion/parameters.py
##########
@@ -89,6 +89,13 @@ def wrapped_function(*args, **kwargs):
return format_parameters_decorator
+def apply_array_filter(query, key, values):
Review comment:
Could you also add type annotation to this function?
##########
File path: airflow/api_connexion/endpoints/task_instance_endpoint.py
##########
@@ -120,7 +114,7 @@ def get_task_instances(
end_date_lte: Optional[str] = None,
duration_gte: Optional[float] = None,
duration_lte: Optional[float] = None,
- state: Optional[str] = None,
+ state: Optional[List[str]] = None,
Review comment:
So the previous annotation was wrong, right? The value passed would
would be `List[str]` even before this change, this simply fixes the type
annotation to match reality, from what I can tell.
##########
File path: airflow/api_connexion/endpoints/dag_run_endpoint.py
##########
@@ -218,6 +226,7 @@ def get_dag_runs_batch(session):
data["execution_date_lte"],
data["start_date_gte"],
data["start_date_lte"],
+ date["state"],
Review comment:
```suggestion
data["state"],
```
Oops
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
