ashb commented on a change in pull request #16681:
URL: https://github.com/apache/airflow/pull/16681#discussion_r665497589
##########
File path: airflow/utils/state.py
##########
@@ -180,6 +184,11 @@ def color_fg(cls, state):
A list of states indicating that a task or dag is a success state.
"""
+ terminated_states = frozenset([TaskInstanceState.SHUTDOWN,
TaskInstanceState.RESTARTING])
Review comment:
```suggestion
terminating_states = frozenset([TaskInstanceState.SHUTDOWN,
TaskInstanceState.RESTARTING])
```
(update docs too etc please)
##########
File path: airflow/utils/state.py
##########
@@ -180,6 +184,11 @@ def color_fg(cls, state):
A list of states indicating that a task or dag is a success state.
"""
+ terminated_states = frozenset([TaskInstanceState.SHUTDOWN,
TaskInstanceState.RESTARTING])
Review comment:
```suggestion
terminating_states = frozenset([TaskInstanceState.SHUTDOWN,
TaskInstanceState.RESTARTING])
```
(update docs/comments too etc please)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
