ashb commented on a change in pull request #16681:
URL: https://github.com/apache/airflow/pull/16681#discussion_r665299592
##########
File path: airflow/models/dagrun.py
##########
@@ -487,7 +487,9 @@ def task_instance_scheduling_decisions(self, session:
Session = None) -> TISched
schedulable_tis: List[TI] = []
changed_tis = False
- tis = list(self.get_task_instances(session=session,
state=State.task_states + (State.SHUTDOWN,)))
+ tis = list(
+ self.get_task_instances(session=session, state=State.task_states +
tuple(State.terminated_states))
+ )
Review comment:
It's not clear to me why `State.SHUTDOWN` wasn't in task_states before,
but it looks like Andew fixed that in #15285, so this can just become
```suggestion
tis = list(self.get_task_instances(session=session,
state=State.task_states))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
